Skip to content

Conversation

@just-boris
Copy link
Member

@just-boris just-boris commented Sep 11, 2025

Description

Port that change cloudscape-design/components#3802 to the current package

Related links, issue #, if available: n/a

How has this been tested?

PR build

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@just-boris just-boris requested a review from a team as a code owner September 11, 2025 15:38
@just-boris just-boris requested review from teodoranemes and removed request for a team September 11, 2025 15:38
@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.00%. Comparing base (a61290b) to head (efeb626).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
- Coverage   95.42%   95.00%   -0.43%     
==========================================
  Files          67       67              
  Lines        3282     3282              
  Branches      706      703       -3     
==========================================
- Hits         3132     3118      -14     
- Misses        150      164      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@teodoranemes teodoranemes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the failing visual tests related to changes in this PR, or are they pre-existing issues?

@just-boris
Copy link
Member Author

Pre-existing issues. There are flaky tests. See this one from the PR build logs, for example:

drag-states-test-ts-resizes-4-x-2-item-down-to-2-x-1-one-step-at-a-time-2-snap-diff

@just-boris just-boris added this pull request to the merge queue Sep 12, 2025
Merged via the queue into main with commit 448b9f7 Sep 12, 2025
39 of 40 checks passed
@just-boris just-boris deleted the documenter-migration branch September 12, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants