Skip to content

chore: Fix flaky test #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
just-boris merged 1 commit into from
Feb 19, 2025
Merged

chore: Fix flaky test #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/compare-images.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,10 @@ test(
test(
'should compare viewport screenshots',
setupTest(async (page, browser) => {
await page.waitForJsTimers(200);
const firstResult = await page.captureViewport();
await browser.refresh();
await page.waitForJsTimers(200);
Copy link
Member Author

@just-boris just-boris Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gradually increased this value until the build passed

Copy link
Member

@orangevolon orangevolon Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid fluctuations, does it make sense to go slightly over the passed value?

Copy link
Member Author

@just-boris just-boris Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can assume the current value is already "slightly over". To find the exact timing, I am doing additional investigation in #134

const secondResult = await page.captureViewport();
await expect(cropAndCompare(firstResult, secondResult)).resolves.toEqual({
firstImage: expect.any(Buffer),
Expand Down
Loading