Skip to content

Conversation

@jperals
Copy link
Member

@jperals jperals commented Sep 30, 2025

Description

Same as cloudscape-design/demos#217 and cloudscape-design/components#739.

How has this been tested?

The change has worked in other repos, but we need to merge the change in order to tell it definitely works.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jperals jperals requested a review from a team as a code owner September 30, 2025 07:34
@jperals jperals requested review from YueyingLu and removed request for a team September 30, 2025 07:34
@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.57%. Comparing base (dab1730) to head (186ace9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   93.57%   93.57%           
=======================================
  Files           7        7           
  Lines         249      249           
  Branches       57       57           
=======================================
  Hits          233      233           
  Misses         14       14           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

just-boris
just-boris previously approved these changes Sep 30, 2025
@jperals jperals enabled auto-merge September 30, 2025 07:54
@jperals jperals added this pull request to the merge queue Sep 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 30, 2025
@jperals jperals added this pull request to the merge queue Sep 30, 2025
@jperals jperals removed this pull request from the merge queue due to the queue being cleared Sep 30, 2025
- opened
- edited
- synchronize

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to specify the branch because the merge queue is only enabled for main. Same as in components: cloudscape-design/components#743 (comment)

@ernst-dev ernst-dev added this pull request to the merge queue Oct 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 1, 2025
@jperals jperals added this pull request to the merge queue Oct 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 1, 2025
@ernst-dev ernst-dev added this pull request to the merge queue Oct 1, 2025
Merged via the queue into main with commit 3b9966b Oct 1, 2025
42 checks passed
@ernst-dev ernst-dev deleted the chore/merge-queue-checks branch October 1, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants