fix: Adjusting chart tooltip position on resize #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan-kot
force-pushed
the
fix-adjust-tooltip-pos-on-resize
branch
from
efd996e to
a02f740
Compare
jperals
reviewed
Nov 19, 2025
| private targetTrack = new SVGRendererSingle(); | ||
| private groupTrack = new SVGRendererSingle(); | ||
|
|
||
| // Cached coordinates to update cursor's position on re-render. |
Member
There was a problem hiding this comment.
If fixes were necessary on this package's side, shouldn't we have some coverage for this too?
Member
Author
There was a problem hiding this comment.
Makes sense!
I updated the test page so that it opens the split panel on the given point on the page load, so that the screenshot test captures the desired outcome.
pan-kot
force-pushed
the
fix-adjust-tooltip-pos-on-resize
branch
from
a02f740 to
4a1858d
Compare
jperals
approved these changes
Nov 24, 2025
jsilll
pushed a commit
to jsilll/chart-components
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The tooltip position on split panel open is fixed here: cloudscape-design/components#3958
In this PR I add a new test page to validate the behaviour and also fix the cartesian cursor, which should also recompute in case chart's width change.
Rel: AWSUI-61377
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.