Skip to content

Conversation

@pan-kot
Copy link
Member

@pan-kot pan-kot commented Nov 5, 2025

Description

The PR adds test pages to validate this fix: cloudscape-design/components#4005 works.

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jperals
Copy link
Member

jperals commented Nov 5, 2025

Two questions:

@pan-kot
Copy link
Member Author

pan-kot commented Nov 6, 2025

Two questions:

  1. The issue was in the chart popover, which is imported by chart-components (via internal do-not-use namespace).
  2. I don't think we need to cover it here with automation as the actual behaviour is already well tested in the components repo. However, I find that having an iframe testing page is useful as there might be more issues like that discovered in the future.

@pan-kot pan-kot added this pull request to the merge queue Nov 6, 2025
Merged via the queue into main with commit 116234a Nov 6, 2025
43 of 44 checks passed
@pan-kot pan-kot deleted the tooltip-in-iframe-test branch November 6, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants