generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 12
feat: support debouncing of the chart core tooltip #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pan-kot
merged 8 commits into
cloudscape-design:main
from
HrvojeHemen:debounce-tooltip-wip
Dec 4, 2025
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c903809
feat: support debouncing of the chart core tooltip
9edf5c0
Merge branch 'cloudscape-design:main' into debounce-tooltip-wip
HrvojeHemen a510085
feat: support debouncing of the chart core tooltip v3
8d6b937
remove testing changes
294381f
remove `?` from debouncedTooltip because we're checking whether it's …
24ab8bf
last `?` remnants that aren't needed
4222caa
Final touches
c309573
component -> value
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| import { useEffect, useRef, useState } from "react"; | ||
|
|
||
| import { DebouncedCall } from "./utils"; | ||
|
|
||
| export function useDebouncedValue<T>(value: T, duration: number) { | ||
| const [debouncedValue, setDebouncedValue] = useState<T | null>(null); | ||
| const [shouldRender, setShouldRender] = useState(false); | ||
| const debouncedCall = useRef(new DebouncedCall()); | ||
|
|
||
| useEffect(() => { | ||
| if (duration <= 0) { | ||
| return; | ||
| } | ||
|
|
||
| setShouldRender(false); | ||
| const current = debouncedCall.current; | ||
| current.call(() => { | ||
| setDebouncedValue(value); | ||
| setShouldRender(true); | ||
| }, duration); | ||
|
|
||
| return () => current.cancelPrevious(); | ||
| }, [value, duration]); | ||
|
|
||
| if (duration <= 0) { | ||
| return value; | ||
| } | ||
|
|
||
| return shouldRender ? debouncedValue : null; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good tests 👍