generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 12
feat: Tooltip series sorting #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pan-kot
merged 8 commits into
cloudscape-design:main
from
Pixselve:legend-items-sorting
Dec 12, 2025
Merged
feat: Tooltip series sorting #130
pan-kot
merged 8 commits into
cloudscape-design:main
from
Pixselve:legend-items-sorting
Dec 12, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new `seriesSorting` property to tooltip options that controls how series items are ordered in tooltips. The property accepts two values: - "asAdded" (default): maintains original series order - "byValue": sorts tooltip items by their values in descending order
Update tooltip series sorting option from "byValue" to "byValueDesc" to explicitly indicate descending sort order. Add comprehensive test coverage for series sorting.
Member
|
Note: the documenter snapshot needs to be updated. You can do this by running |
Contributor
Author
Sorry for missing it. Added in next rev |
jperals
previously approved these changes
Dec 4, 2025
pan-kot
reviewed
Dec 4, 2025
Member
|
Note: there are conflicts to resolve |
# Conflicts: # src/core/__tests__/chart-core-tooltip.test.tsx # src/core/components/core-tooltip.tsx # src/core/interfaces.ts
jperals
reviewed
Dec 12, 2025
Contributor
Author
Resolved |
jperals
previously approved these changes
Dec 12, 2025
pan-kot
previously approved these changes
Dec 12, 2025
pan-kot
approved these changes
Dec 12, 2025
jperals
approved these changes
Dec 12, 2025
Merged
via the queue into
cloudscape-design:main
with commit Dec 12, 2025
512e840
42 of 44 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows sorting series in a data tooltip by their point
yvalues.How has this been tested?
Updated CoreLine page:
2025-11-26_13-24-12.mp4
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.