Skip to content

Conversation

@Pixselve
Copy link
Contributor

Description

Allows sorting series in a data tooltip by their point y values.

How has this been tested?

Updated CoreLine page:

2025-11-26_13-24-12.mp4
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Add a new `seriesSorting` property to tooltip options that controls how series items are ordered in tooltips. The property accepts two values:
- "asAdded" (default): maintains original series order
- "byValue": sorts tooltip items by their values in descending order
Update tooltip series sorting option from "byValue" to "byValueDesc"
to explicitly indicate descending sort order. Add comprehensive test
coverage for series sorting.
@Pixselve Pixselve changed the title feat: Legend items sorting feat: Tooltip series sorting Nov 26, 2025
@jperals
Copy link
Member

jperals commented Dec 4, 2025

Note: the documenter snapshot needs to be updated.

You can do this by running

npx vitest run --config vite.config.unit.mjs -u src/__tests__/documenter.test.ts

@Pixselve
Copy link
Contributor Author

Pixselve commented Dec 4, 2025

Note: the documenter snapshot needs to be updated.

You can do this by running

npx vitest run --config vite.config.unit.mjs -u src/__tests__/documenter.test.ts

Sorry for missing it. Added in next rev

jperals
jperals previously approved these changes Dec 4, 2025
@Pixselve Pixselve requested a review from a team as a code owner December 9, 2025 11:33
@Pixselve Pixselve requested review from jperals and pan-kot and removed request for a team December 9, 2025 11:33
@jperals
Copy link
Member

jperals commented Dec 10, 2025

Note: there are conflicts to resolve

# Conflicts:
#	src/core/__tests__/chart-core-tooltip.test.tsx
#	src/core/components/core-tooltip.tsx
#	src/core/interfaces.ts
@Pixselve
Copy link
Contributor Author

Note: there are conflicts to resolve

Resolved

jperals
jperals previously approved these changes Dec 12, 2025
pan-kot
pan-kot previously approved these changes Dec 12, 2025
@pan-kot pan-kot dismissed stale reviews from jperals and themself via adc189c December 12, 2025 12:26
@pan-kot pan-kot requested a review from jperals December 12, 2025 12:26
@pan-kot pan-kot added this pull request to the merge queue Dec 12, 2025
Merged via the queue into cloudscape-design:main with commit 512e840 Dec 12, 2025
42 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants