Skip to content

Conversation

@teodoranemes
Copy link
Contributor

@teodoranemes teodoranemes commented Aug 12, 2025

Description

This PR is a revert of #79 , after the validateProps method that was causing a failure was moved from the components package to the component-toolkit package.
For more context, check:

How has this been tested?

Tested in the personal pipeline.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.17%. Comparing base (288b8c9) to head (1541327).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   95.85%   96.17%   +0.31%     
==========================================
  Files          28       29       +1     
  Lines         628      679      +51     
  Branches       94      114      +20     
==========================================
+ Hits          602      653      +51     
  Misses         26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@teodoranemes teodoranemes marked this pull request as ready for review August 12, 2025 09:42
@teodoranemes teodoranemes requested a review from a team as a code owner August 12, 2025 09:42
@teodoranemes teodoranemes requested review from johannes-weber and removed request for a team August 12, 2025 09:42
@teodoranemes teodoranemes added this pull request to the merge queue Aug 12, 2025
Merged via the queue into main with commit ea1951d Aug 12, 2025
40 checks passed
@teodoranemes teodoranemes deleted the avatar-style branch August 12, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants