Skip to content

Conversation

@jperals
Copy link
Member

@jperals jperals commented Dec 5, 2025

Description

Disable animations when taking screenshots, to make visual regression tests more stable.

How has this been tested?

  • Verified locally that the spinner causing visual regression failures does not move
  • Verified that the only visual regression test failure in the PR checks is because of that known spinner. This should go away once this PR is merged.
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.17%. Comparing base (4211f2e) to head (0970ee9).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   96.17%   96.17%           
=======================================
  Files          29       29           
  Lines         679      679           
  Branches      114      114           
=======================================
  Hits          653      653           
  Misses         26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jperals jperals marked this pull request as ready for review December 5, 2025 17:04
@jperals jperals requested a review from a team as a code owner December 5, 2025 17:04
@jperals jperals requested review from pan-kot and removed request for a team December 5, 2025 17:04
@jperals jperals added this pull request to the merge queue Dec 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 10, 2025
@jperals jperals added this pull request to the merge queue Dec 10, 2025
Merged via the queue into main with commit aa8566e Dec 10, 2025
46 of 47 checks passed
@jperals jperals deleted the chore/remove-animations branch December 10, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants