-
Notifications
You must be signed in to change notification settings - Fork 10
feat: Adds support for table data grouping #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
410913a
feat: Adds support for table data grouping
pan-kot 8864cc5
adds (total) selected items count
pan-kot 8d76a8f
minor change to group-selection-change type
pan-kot b037182
Minor code refactor
pan-kot 29a5ed0
small refactorings as per feedback
pan-kot da3461f
take deps from toolkit
pan-kot 3ec1928
add prepare-deps script
pan-kot d61b09e
revert lib.dom change
pan-kot 92f0795
use build-tools
pan-kot 7c5807a
refactor property based tests
pan-kot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| #!/usr/bin/env node | ||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| /* eslint-disable no-undef */ | ||
|
|
||
| import fs from 'node:fs'; | ||
|
|
||
| const lockfiles = ['package-lock.json']; | ||
|
|
||
| for (const filename of lockfiles) { | ||
| unlock(filename); | ||
| } | ||
|
|
||
| /** | ||
| * Remove specific @cloudscape-design/* packages where we should always use the latest minor release. | ||
| */ | ||
| function unlock(filename) { | ||
| const packageLock = JSON.parse(fs.readFileSync(filename)); | ||
| if (packageLock.lockfileVersion !== 3) { | ||
| throw Error('package-lock.json file is not version 3. Use regular npm to update the packages.'); | ||
| } | ||
|
|
||
| Object.keys(packageLock.packages).forEach(dependencyName => { | ||
| removeDependencies(dependencyName, packageLock.packages); | ||
| }); | ||
|
|
||
| fs.writeFileSync(filename, JSON.stringify(packageLock, null, 2) + '\n'); | ||
| console.log(`Removed @cloudscape-design/ dependencies from ${filename} file`); | ||
| } | ||
|
|
||
| function removeDependencies(dependencyName, packages) { | ||
| if (dependencyName.includes('@cloudscape-design/')) { | ||
| delete packages[dependencyName]; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not add it to the build-tools package instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of doing that as a follow up, since there are slightly different versions of this script across packages, but it should be easy to do it right away - I will take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cloudscape-design/build-tools#29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done