Skip to content

Conversation

@pan-kot
Copy link
Member

@pan-kot pan-kot commented May 5, 2025

Moves portal from https://github.com/cloudscape-design/components/tree/main/src/internal/components/portal to toolkit, to be reused in chart components.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pan-kot pan-kot requested a review from a team as a code owner May 5, 2025 05:56
@pan-kot pan-kot requested review from jperals and removed request for a team May 5, 2025 05:56
@codecov
Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.33%. Comparing base (b062d4f) to head (53597b4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
+ Coverage   99.30%   99.33%   +0.03%     
==========================================
  Files          29       30       +1     
  Lines         717      751      +34     
  Branches      192      199       +7     
==========================================
+ Hits          712      746      +34     
  Misses          5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pan-kot pan-kot added this pull request to the merge queue May 5, 2025
Merged via the queue into main with commit fd512d9 May 5, 2025
36 checks passed
@pan-kot pan-kot deleted the internal-portal branch May 5, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants