Skip to content

Conversation

@just-boris
Copy link
Member

@just-boris just-boris commented Aug 19, 2025

Issue #, if available:

Description of changes:

This works today, but not allowed by types

metrics.sendOpsMetricObject('awsui-ops-demo', { somethingCount: 1 });

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@just-boris just-boris requested a review from a team as a code owner August 19, 2025 16:14
@just-boris just-boris requested review from avinashbot and removed request for a team August 19, 2025 16:14
@just-boris just-boris changed the title allow booleans and numbers in metric detail chore: allow booleans and numbers in metric detail Aug 19, 2025
@just-boris just-boris enabled auto-merge (squash) August 19, 2025 16:14
@codecov
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.40%. Comparing base (beaa531) to head (0c6b90e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #153   +/-   ##
=======================================
  Coverage   99.40%   99.40%           
=======================================
  Files          34       34           
  Lines         840      840           
  Branches      227      240   +13     
=======================================
  Hits          835      835           
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@just-boris just-boris merged commit c338b2d into main Aug 20, 2025
64 of 67 checks passed
@just-boris just-boris deleted the metric-types branch August 20, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants