Skip to content

Commit efa73c0

Browse files
committed
Fix tests
1 parent a652af2 commit efa73c0

File tree

4 files changed

+12
-6
lines changed

4 files changed

+12
-6
lines changed

src/app-layout/__tests__/toolbar.test.tsx

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import { describeEachAppLayout, manyDrawers, renderComponent } from './utils';
77

88
import AppLayout from '../../../lib/components/app-layout';
99
import SplitPanel from '../../../lib/components/split-panel';
10+
import testUtilsStyles from '../../../lib/components/app-layout/test-classes/styles.css.js';
1011

1112
// no-op function to suppress controllability warnings
1213
function noop() {}
@@ -39,7 +40,9 @@ describe('toolbar mode only features', () => {
3940
<AppLayout splitPanel={<SplitPanel header="Testing">Dummy for testing</SplitPanel>} />
4041
);
4142
expect(wrapper.findToolbar()).toBeTruthy();
42-
expect(wrapper.findToolbar()!.getElement()).toContainElement(wrapper.findSplitPanelOpenButton()!.getElement());
43+
expect(wrapper.findToolbar()!.getElement()).toContainElement(
44+
wrapper.findByClassName(testUtilsStyles['split-panel-trigger'])!.getElement()
45+
);
4346
});
4447

4548
test('renders toolbar with split panel trigger in active state', () => {
@@ -51,8 +54,9 @@ describe('toolbar mode only features', () => {
5154
/>
5255
);
5356
expect(wrapper.findToolbar()).toBeTruthy();
54-
expect(wrapper.findToolbar()!.getElement()).toContainElement(wrapper.findSplitPanelOpenButton()!.getElement());
55-
expect(wrapper.findSplitPanelOpenButton()!.getElement()).toHaveAttribute('aria-expanded', 'true');
57+
const splitPanelTrigger = wrapper.findByClassName(testUtilsStyles['split-panel-trigger'])!.getElement();
58+
expect(wrapper.findToolbar()!.getElement()).toContainElement(splitPanelTrigger);
59+
expect(splitPanelTrigger).toHaveAttribute('aria-expanded', 'true');
5660
});
5761

5862
// skip on desktop because requires element queries to work

src/app-layout/__tests__/widget-compatibility.test.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,13 +108,13 @@ test('renders visual refresh toolbar with navigation using legacy props', () =>
108108
test('renders visual refresh toolbar with split panel using toolbarProps', () => {
109109
const onSplitPanelToggle = jest.fn();
110110
renderNewAppLayout({ toolbarProps: { onSplitPanelToggle } });
111-
wrapper.findByClassName(splitPanelTestUtilStyles['open-button'])!.click();
111+
wrapper.findByClassName(splitPanelTestUtilStyles['split-panel-trigger'])!.click();
112112
expect(onSplitPanelToggle).toHaveBeenCalled();
113113
});
114114

115115
test('renders visual refresh toolbar with split panel using legacy props', () => {
116116
const onSplitPanelToggle = jest.fn();
117117
renderLegacyAppLayout({ appLayoutInternals: { onSplitPanelToggle } });
118-
wrapper.findByClassName(splitPanelTestUtilStyles['open-button'])!.click();
118+
wrapper.findByClassName(testUtilsStyles['split-panel-trigger'])!.click();
119119
expect(onSplitPanelToggle).toHaveBeenCalled();
120120
});

src/app-layout/test-classes/styles.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
.drawers-trigger,
2020
.drawers-trigger-global,
2121
.drawers-trigger-with-badge,
22+
.split-panel-trigger,
2223
.active-drawer,
2324
.active-drawer-close-button,
2425
.overflow-menu,

src/app-layout/visual-refresh-toolbar/toolbar/drawer-triggers.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,9 +136,10 @@ export function DrawerTriggers({
136136
className={clsx(
137137
styles['drawers-trigger'],
138138
testutilStyles['drawers-trigger'],
139+
testutilStyles['split-panel-trigger'],
139140
splitPanelResolvedPosition === 'side' && splitPanelTestUtilStyles['open-button']
140141
)}
141-
iconName={splitPanelToggleProps.position === 'side' ? 'view-vertical' : 'view-horizontal'}
142+
iconName={splitPanelResolvedPosition === 'side' ? 'view-vertical' : 'view-horizontal'}
142143
onClick={() => onSplitPanelToggle?.()}
143144
selected={splitPanelToggleProps.active}
144145
ref={splitPanelResolvedPosition === 'side' ? splitPanelFocusRef : undefined}

0 commit comments

Comments
 (0)