feat: Public layout component #3208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3208 +/- ##
=======================================
Coverage 96.42% 96.43%
=======================================
Files 791 793 +2
Lines 22611 22665 +54
Branches 7814 7839 +25
=======================================
+ Hits 21803 21857 +54
Misses 754 754
Partials 54 54 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
georgylobko
commented
Jan 21, 2025
pages/page-layout/styles.scss
Outdated
Member
Author
There was a problem hiding this comment.
These styles were copied from pages/app-layout
…mponent # Conflicts: # src/__tests__/snapshot-tests/__snapshots__/test-utils-wrappers.test.tsx.snap
…vided nor at least one drawer with trigger
just-boris
reviewed
Feb 18, 2025
| import { awsuiPluginsInternal } from '../../internal/plugins/api'; | ||
| import { RegistrationState } from '../../internal/plugins/controllers/app-layout-widget'; | ||
| import { AppLayoutProps } from '../interfaces'; | ||
| import { useAppLayoutToolbarEnabled } from '../utils/feature-flags'; |
Member
There was a problem hiding this comment.
Let's rename these hooks
- useAppLayoutFlagEnabled – the feature flags are active (for all advanced deduplication features)
- useAppLayoutToolbarDesignEnabled - same as above, but also true when toolbar is used standalone
Comment on lines
+17
to
+24
| beforeEach(() => { | ||
| globalWithFlags[Symbol.for('awsui-visual-refresh-flag')] = () => true; | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| delete globalWithFlags[Symbol.for('awsui-visual-refresh-flag')]; | ||
| clearVisualRefreshState(); | ||
| }); |
Member
There was a problem hiding this comment.
Discussed offline, let's undo the change about useVisualRefresh and keep it this way until the PR is merged
…h-flag')] to useVisualRefresh in functional tests" This reverts commit 273633b.
just-boris
approved these changes
Mar 10, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
doc: tb1MA6m8ZZEt
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.