Skip to content

Conversation

@just-boris
Copy link
Member

Description

Unblock the build for this fix: cloudscape-design/component-toolkit#116

Related links, issue #, if available: n/a

How has this been tested?

No visual changes, PR build only will be enough

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.45%. Comparing base (bcb11cb) to head (99cfb9c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3234      +/-   ##
==========================================
- Coverage   96.45%   96.45%   -0.01%     
==========================================
  Files         791      790       -1     
  Lines       22315    22299      -16     
  Branches     7667     7249     -418     
==========================================
- Hits        21524    21508      -16     
- Misses        739      784      +45     
+ Partials       52        7      -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@just-boris just-boris requested a review from taheramr January 30, 2025 11:26
@just-boris just-boris marked this pull request as ready for review January 30, 2025 11:26
@just-boris just-boris requested a review from a team as a code owner January 30, 2025 11:26
@just-boris just-boris removed the request for review from a team January 30, 2025 11:27
@just-boris just-boris added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit 9a18a8c Jan 30, 2025
38 checks passed
@just-boris just-boris deleted the remove-flashbar-metrics branch January 30, 2025 12:09
georgylobko pushed a commit that referenced this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants