Skip to content

fix: Ensure focus is returned to active tab#3266

Merged
gethinwebster merged 1 commit intomainfrom
tab-focus-fix
Feb 7, 2025
Merged

fix: Ensure focus is returned to active tab#3266
gethinwebster merged 1 commit intomainfrom
tab-focus-fix

Conversation

@gethinwebster
Copy link
Member

Description

Ensure that tab focus is returned consistently to the active tab, whether or not tabs have actions.

Related links, issue #, if available: n/a

How has this been tested?

Updated tests

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@gethinwebster gethinwebster requested a review from a team as a code owner February 7, 2025 15:20
@gethinwebster gethinwebster requested review from pan-kot and removed request for a team February 7, 2025 15:20
@codecov
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (6c6453d) to head (884ac47).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3266    +/-   ##
========================================
  Coverage   96.44%   96.44%            
========================================
  Files         791      791            
  Lines       22567    22567            
  Branches     7731     7384   -347     
========================================
  Hits        21764    21764            
- Misses        750      796    +46     
+ Partials       53        7    -46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pan-kot pan-kot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@gethinwebster gethinwebster added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit b29b255 Feb 7, 2025
38 checks passed
@gethinwebster gethinwebster deleted the tab-focus-fix branch February 7, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants