Skip to content

Conversation

@just-boris
Copy link
Member

Description

Re-enable snapshot tests after cloudscape-design/documenter#58 is released

Related links, issue #, if available: n/a

How has this been tested?

Build passes

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Comment on lines +28 to +31
extraExports: {
FileDropzone: ['useFilesDragging'],
TagEditor: ['getTagsDiff'],
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New feature, if component exports something else beside default export and ComponentProps types, it needs to be declared here

This is needed to prevent "public by accident" exports

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can review this snapshot diff here: 9750e0a...ed2b2f5

@codecov
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.50%. Comparing base (8fe8792) to head (ed2b2f5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3413   +/-   ##
=======================================
  Coverage   96.50%   96.50%           
=======================================
  Files         804      804           
  Lines       23006    23006           
  Branches     7543     7543           
=======================================
  Hits        22201    22201           
  Misses        798      798           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@just-boris just-boris marked this pull request as ready for review April 9, 2025 13:13
@just-boris just-boris requested a review from a team as a code owner April 9, 2025 13:13
@just-boris just-boris requested review from ernst-dev and removed request for a team April 9, 2025 13:13
@just-boris just-boris added this pull request to the merge queue Apr 9, 2025
Merged via the queue into main with commit e6c589b Apr 9, 2025
38 checks passed
@just-boris just-boris deleted the disable-documenter branch April 9, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants