Skip to content

Conversation

@avinashbot
Copy link
Member

@avinashbot avinashbot commented Jul 11, 2025

Description

See cloudscape-design/component-toolkit#143 for more details. This can't merge until that PR merges first, so the build failure is kinda intentional.

Related links, issue #, if available: AWSUI-60845

How has this been tested?

In a dev pipeline, both automated and manual (see the dropdown/expandable-iframe page). Additional tests for this behavior are also handled in the component-toolkit package.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@avinashbot avinashbot force-pushed the focus-visible-toolkit branch from dcd1c81 to da4d59d Compare July 16, 2025 11:45
@codecov
Copy link

codecov bot commented Jul 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.62%. Comparing base (49fb1b7) to head (50516d5).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3642   +/-   ##
=======================================
  Coverage   96.62%   96.62%           
=======================================
  Files         818      818           
  Lines       23805    23805           
  Branches     8276     8342   +66     
=======================================
  Hits        23002    23002           
- Misses        749      796   +47     
+ Partials       54        7   -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avinashbot avinashbot marked this pull request as ready for review July 18, 2025 09:59
@avinashbot avinashbot requested a review from a team as a code owner July 18, 2025 09:59
@avinashbot avinashbot requested review from gethinwebster and removed request for a team July 18, 2025 09:59
@avinashbot avinashbot added this pull request to the merge queue Jul 18, 2025
Merged via the queue into main with commit 0ed050e Jul 18, 2025
38 checks passed
@avinashbot avinashbot deleted the focus-visible-toolkit branch July 18, 2025 14:19
Al-Dani pushed a commit that referenced this pull request Jul 21, 2025
pranshuteotia pushed a commit to pranshuteotia/components that referenced this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants