chore: Add dnd drag buttons to list #3652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gethinwebster
force-pushed
the
dev-v3-gethinw-list-sortable-dnd
branch
from
d496347 to
f73fd82
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3652 +/- ##
=======================================
Coverage 97.01% 97.02%
=======================================
Files 835 835
Lines 24142 24168 +26
Branches 8414 8500 +86
=======================================
+ Hits 23422 23449 +27
+ Misses 671 670 -1
Partials 49 49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gethinwebster
force-pushed
the
dev-v3-gethinw-list-sortable-dnd
branch
from
f73fd82 to
4d6bf1e
Compare
gethinwebster
force-pushed
the
dev-v3-gethinw-list-sortable-dnd
branch
from
4d6bf1e to
7c5814b
Compare
gethinwebster
force-pushed
the
dev-v3-gethinw-list-sortable-dnd
branch
from
7c5814b to
884debb
Compare
just-boris
previously approved these changes
Aug 7, 2025
| await page.expectAnnouncement('Moving item to position 2 of 6'); | ||
|
|
||
| await page.click(page.wrapper.findModal().findContentDisplayPreference().findTitle().toSelector()); | ||
| await expect(await page.containsOptionsInOrder(['Item 2', 'Item 1'])).toBe(true); |
There was a problem hiding this comment.
Could avoid an extra await
Suggested change
| await expect(await page.containsOptionsInOrder(['Item 2', 'Item 1'])).toBe(true); | |
| await expect(page.containsOptionsInOrder(['Item 2', 'Item 1'])).resolves.toBe(true); |
| describe('internal icon props', () => { | ||
| test('should prevent pointer events', () => { | ||
| const { container } = render(<InternalIcon name="add-plus" __preventPointerEvents={true} />); | ||
| expect(container.querySelector('span')).toHaveClass(styles['prevent-pointer-events']); |
There was a problem hiding this comment.
Can we use styles.icon selector instead of any span?
src/icon/internal.tsx
Outdated
| @@ -16,6 +16,7 @@ import styles from './styles.css.js'; | |||
| type InternalIconProps = IconProps & | |||
| InternalBaseComponentProps & { | |||
| badge?: boolean; | |||
| __preventPointerEvents?: boolean; | |||
There was a problem hiding this comment.
is it possible to avoid modifying the icon for this case?
Can pointer-events be applied somewhere on a parent DOM node?
There was a problem hiding this comment.
good idea, updated
| @@ -18,23 +18,35 @@ import { EventName } from './utilities/events'; | |||
| import { Listeners } from './utilities/listeners'; | |||
| import { applyScroll } from './utilities/scroll'; | |||
|
|
|||
| // Slightly modified version of @dnd-kit's KeyboardSensor: | |||
| // Modified version of @dnd-kit's KeyboardSensor: | |||
There was a problem hiding this comment.
Do you think if at this point we should abandon idea of ever switching back to upstream and maintain this code as fully our own?
There was a problem hiding this comment.
yes, I was basically seeing it as that, I'll update the comment to make that a bit clearer
gethinwebster
force-pushed
the
dev-v3-gethinw-list-sortable-dnd
branch
from
884debb to
bf73e54
Compare
just-boris
previously approved these changes
Aug 15, 2025
just-boris
approved these changes
Aug 15, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add pointer-only/"UAP" buttons to sortable list
Related links, issue #, if available: AWSUI-61051
How has this been tested?
New unit and integ tests
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.