Skip to content

Conversation

orangevolon
Copy link
Member

Description

Adds disabled state to two components:

  • File input
  • File token group

Note on file token group: This component already has a similar property of readOnly which completely removes the dismiss button. The only difference between readOnly and disabled is that disabled keeps the dismiss button but disables it.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

pan-kot
pan-kot previously approved these changes Jul 17, 2025
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.62%. Comparing base (7fbd0fb) to head (54a37e7).

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3659    +/-   ##
========================================
  Coverage   96.62%   96.62%            
========================================
  Files         817      817            
  Lines       23782    23784     +2     
  Branches     8269     7914   -355     
========================================
+ Hits        22979    22981     +2     
- Misses        749      796    +47     
+ Partials       54        7    -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@orangevolon orangevolon force-pushed the alamiami/adds-disabled-state-to-file-input branch from 54a37e7 to eb6e153 Compare July 17, 2025 14:24
@orangevolon orangevolon force-pushed the alamiami/adds-disabled-state-to-file-input branch from eb6e153 to 4d05e0d Compare July 18, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants