chore: Migrate to new test-utils documenter #3693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just-boris
commented
Jul 28, 2025
|
|
||
| function testUtilDocs() { | ||
| ['dom', 'selectors'].forEach(testUtilType => { | ||
| const baseWrapperDefinitions = require(`@cloudscape-design/test-utils-core/test-utils-doc/${testUtilType}`); |
Member
Author
There was a problem hiding this comment.
NB: in the old version we used to mix the base classes into this documentation. it should not be happening anymore
The consuming code will import them explicitly
just-boris
force-pushed
the
documenter-migration
branch
4 times, most recently
from
40a29f5 to
b81186d
Compare
just-boris
commented
Jul 31, 2025
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| import definitions from '../../../lib/components-definitions/components'; | ||
| // @ts-expect-error no typings |
Member
Author
There was a problem hiding this comment.
now there are typings
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3693 +/- ##
=======================================
Coverage 96.96% 96.96%
=======================================
Files 820 820
Lines 23785 23785
Branches 8338 8346 +8
=======================================
Hits 23063 23063
Misses 673 673
Partials 49 49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
taheramr
previously approved these changes
Aug 1, 2025
just-boris
force-pushed
the
documenter-migration
branch
from
b81186d to
918abb7
Compare
taheramr
approved these changes
Aug 1, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
just-boris
added a commit
that referenced
this pull request
Aug 4, 2025
This reverts commit 0cea5f4.
mariksav
pushed a commit
that referenced
this pull request
Aug 7, 2025
pranshuteotia
pushed a commit
to pranshuteotia/components
that referenced
this pull request
Sep 3, 2025
pranshuteotia
pushed a commit
to pranshuteotia/components
that referenced
this pull request
Sep 3, 2025
at-susie
pushed a commit
that referenced
this pull request
Oct 10, 2025
at-susie
pushed a commit
that referenced
this pull request
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate to the new version implemented here: cloudscape-design/documenter#77
Related links, issue #, if available: n/a
How has this been tested?
PR build
Reviewed snapshot tests diff, all good
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.