feat: Add support for download links in ButtonDropdown #3694
Conversation
This PR adds the ability to specify `download: true` for an item in a `ButtonDropdown`, in conjunction with an `href`, to get a download link instead of a normal link. This matches the behavior of the `download` prop on the `Button` component.
gethinwebster
changed the title
| expect(item.getElement()).toHaveTextContent('Button item'); | ||
| }); | ||
|
|
||
| it('should not render download attribute when item is disabled', () => { |
There was a problem hiding this comment.
The link is already not clickable when disabled. Why do we want to remove the download attribute?
There was a problem hiding this comment.
Honestly, Claude added this. I agree that it doesn't really matter. The Button component keeps the download attribute when it's disabled.
| @@ -165,7 +167,7 @@ export namespace ButtonDropdownProps { | |||
| } | |||
|
|
|||
| export interface CheckboxItem | |||
| extends Omit<ButtonDropdownProps.Item, 'href' | 'external' | 'externalIconAriaLabel' | 'itemType'> { | |||
| extends Omit<ButtonDropdownProps.Item, 'href' | 'download' | 'external' | 'externalIconAriaLabel' | 'itemType'> { | |||
There was a problem hiding this comment.
Wondering if we need a visual clue for download similar to external.
There was a problem hiding this comment.
In practice, I think we'd want to use iconName="download" whenever we use the download attribute. But I don't think that should be enforced; someone might want to use a different (custom?) icon to differentiate some downloads.
Having download and iconName as orthogonal options matches the API of the Button component.
This PR adds the ability to specify
download: truefor an item in aButtonDropdown, in conjunction with anhref, to get a download link instead of a normal link. This matches the behavior of thedownloadprop on theButtoncomponent.How has this been tested?
I've added unit tests as part of this PR.
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.