fix: prevent double discovered breadcrumbs#3714
Merged
just-boris merged 2 commits intomainfrom Aug 4, 2025
Merged
Conversation
just-boris
commented
Aug 2, 2025
| }); | ||
| return () => { | ||
| unregisterAppLayout?.(); | ||
| setDiscoveredBreadcrumbs(null); |
Member
Author
There was a problem hiding this comment.
This is what happened. We need to clean up discoveredBreadcrumbs value if it is not used
This reverts commit 23ed0c7.
just-boris
force-pushed
the
global-breadcrumbs-fix
branch
from
7b64a75 to
54b3284
Compare
just-boris
commented
Aug 2, 2025
| SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| // backward compatibility before this commit: TODO_REPLACE_ME |
Member
Author
There was a problem hiding this comment.
This TODO is expected. I want to put here the commit hash of the current PR which I do not know until it is merged.
I will open a follow up PR to replace
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3714 +/- ##
=======================================
Coverage 96.96% 96.96%
=======================================
Files 820 820
Lines 23786 23789 +3
Branches 8337 8272 -65
=======================================
+ Hits 23064 23067 +3
+ Misses 716 673 -43
- Partials 6 49 +43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
johannes-weber
approved these changes
Aug 4, 2025
pranshuteotia
pushed a commit
to pranshuteotia/components
that referenced
this pull request
Sep 3, 2025
at-susie
pushed a commit
that referenced
this pull request
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Revert this PR: #3704, and also add some extra fixes and tests
Apparently these styles served extra purpose, not only backward compatibility
Related links, issue #, if available: V1881484904
How has this been tested?
Added a regression test
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.