Skip to content

Conversation

teodoranemes
Copy link
Member

@teodoranemes teodoranemes commented Aug 12, 2025

Description

The root focus ring on the Alert was using the generic custom property and this cascades to change the focus for any components in slots. In order to solve this issue, new custom properties were added and namespaced to the Alert.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.01%. Comparing base (58f61d0) to head (983d25a).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3749   +/-   ##
=======================================
  Coverage   97.01%   97.01%           
=======================================
  Files         825      825           
  Lines       23961    23961           
  Branches     8357     8433   +76     
=======================================
  Hits        23246    23246           
  Misses        666      666           
  Partials       49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@teodoranemes teodoranemes marked this pull request as ready for review August 12, 2025 16:06
@teodoranemes teodoranemes requested a review from a team as a code owner August 12, 2025 16:06
@teodoranemes teodoranemes requested review from cansuaa and removed request for a team August 12, 2025 16:06
@teodoranemes teodoranemes requested a review from cansuaa August 15, 2025 14:06
@teodoranemes teodoranemes added this pull request to the merge queue Aug 18, 2025
Merged via the queue into main with commit 2bd2d2f Aug 18, 2025
38 checks passed
@teodoranemes teodoranemes deleted the fix-alert-focus-ring branch August 18, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants