chore: Adds property filter stories unit tests #3751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3751 +/- ##
==========================================
+ Coverage 97.00% 97.04% +0.03%
==========================================
Files 821 825 +4
Lines 23870 23961 +91
Branches 8377 8424 +47
==========================================
+ Hits 23155 23252 +97
- Misses 666 704 +38
+ Partials 49 5 -44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -300,7 +300,6 @@ describe('i18n', () => { | |||
| enableTokenGroups={true} | |||
| filteringOptions={[]} | |||
| customGroupsText={[]} | |||
| disableFreeTextFiltering={false} | |||
teodoranemes
approved these changes
Aug 15, 2025
jperals
pushed a commit
that referenced
this pull request
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR adds more unit tests to the property filter component. Unlike the existing tests, the new tests are all defined for mock components that implement state management and options loading in the expected way. The purpose of the tests is to cover the common user flows: we do not directly assert event handler calls or i18n, but instead verify the observable UI effects.
Rel: AWSUI-59007
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.