-
Notifications
You must be signed in to change notification settings - Fork 208
fix: Fix for async modal roots #4007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e2f8653 to
abecf7f
Compare
| * The function will be called when a user clicks on the trigger button. | ||
| */ | ||
| getModalRoot?: () => Promise<HTMLElement>; | ||
| getModalRoot?: PortalProps['getContainer']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The signature of this function will change. Replacing the manual signature with a type reference to mirror the signature from the upstream without copying
abecf7f to
03bbac9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4007 +/- ##
=======================================
Coverage 97.25% 97.25%
=======================================
Files 859 859
Lines 25394 25394
Branches 9047 9048 +1
=======================================
Hits 24697 24697
+ Misses 691 650 -41
- Partials 6 47 +41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Unblocking this change: cloudscape-design/component-toolkit#172
The code needs to be updated for compatibility with the changes from another package
Related links, issue #, if available: n/a
How has this been tested?
PR build passes
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.