Skip to content

Conversation

@just-boris
Copy link
Member

Description

Move cleanup methods from awsuiPluginsInternal to awsuiPlugins so our consumers can also write unit tests on the runtime API as well

Related links, issue #, if available: n/a

How has this been tested?

Updated related unit tests

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@just-boris just-boris requested a review from a team as a code owner December 18, 2025 16:08
@just-boris just-boris requested review from avinashbot and removed request for a team December 18, 2025 16:08
@just-boris just-boris force-pushed the runtime-api-expose-cleaning branch from f2c82e0 to 1db1895 Compare December 18, 2025 16:32
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.13%. Comparing base (1369fb7) to head (1db1895).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4121   +/-   ##
=======================================
  Coverage   97.13%   97.13%           
=======================================
  Files         873      873           
  Lines       25553    25553           
  Branches     9239     9239           
=======================================
  Hits        24821    24821           
  Misses        726      726           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@just-boris just-boris added this pull request to the merge queue Dec 19, 2025
Merged via the queue into main with commit 0e97d47 Dec 19, 2025
60 of 63 checks passed
@just-boris just-boris deleted the runtime-api-expose-cleaning branch December 19, 2025 11:01
ngynmt pushed a commit to ngynmt/components that referenced this pull request Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants