Skip to content

Conversation

@gethinwebster
Copy link
Member

@gethinwebster gethinwebster commented Dec 19, 2025

Description

This change caused a visual regression: https://github.com/cloudscape-design/components/pull/4114/files#diff-76784505cdd3d68373b0628c8f3c7aa8d45aa14fb2257bc66c0b487e42f906f6R44

It wasn't actually used in the PR in the end, so can safely revert it.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@gethinwebster gethinwebster marked this pull request as ready for review December 19, 2025 07:01
@gethinwebster gethinwebster requested a review from a team as a code owner December 19, 2025 07:01
@gethinwebster gethinwebster requested review from amanabiy and removed request for a team December 19, 2025 07:01
@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.13%. Comparing base (73b6e4a) to head (a7761d1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4124   +/-   ##
=======================================
  Coverage   97.13%   97.13%           
=======================================
  Files         873      873           
  Lines       25553    25553           
  Branches     9239     9240    +1     
=======================================
  Hits        24821    24821           
+ Misses        726      685   -41     
- Partials        6       47   +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timogasda timogasda removed the request for review from amanabiy December 19, 2025 08:17
@gethinwebster gethinwebster added this pull request to the merge queue Dec 19, 2025
Merged via the queue into main with commit 37a490c Dec 19, 2025
119 of 122 checks passed
@gethinwebster gethinwebster deleted the focus-bugfix branch December 19, 2025 08:56
ngynmt pushed a commit to ngynmt/components that referenced this pull request Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants