Skip to content

fix: wrap scrollToIndex in requestAnimationFrame#4132

Merged
mxschll merged 1 commit intomainfrom
dev-v3-schomax-AWSUI-61506
Dec 23, 2025
Merged

fix: wrap scrollToIndex in requestAnimationFrame#4132
mxschll merged 1 commit intomainfrom
dev-v3-schomax-AWSUI-61506

Conversation

@mxschll
Copy link
Member

@mxschll mxschll commented Dec 23, 2025

Description

Fixes incorrect scroll positioning in virtual lists by deferring scrollToIndex calls with requestAnimationFrame. This ensures virtual items are measured before scrolling occurs.

Related links, issue #, if available: n/a

How has this been tested?

Verified changes manually and in pipeline.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mxschll mxschll temporarily deployed to dev-pages-react18 December 23, 2025 10:57 — with GitHub Actions Inactive
@mxschll mxschll temporarily deployed to dev-pages-react16 December 23, 2025 10:57 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.15%. Comparing base (a0df38d) to head (9fe8958).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4132      +/-   ##
==========================================
+ Coverage   97.13%   97.15%   +0.02%     
==========================================
  Files         873      873              
  Lines       25562    25788     +226     
  Branches     9239     9378     +139     
==========================================
+ Hits        24830    25055     +225     
- Misses        726      727       +1     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mxschll mxschll marked this pull request as ready for review December 23, 2025 11:07
@mxschll mxschll requested a review from a team as a code owner December 23, 2025 11:07
@mxschll mxschll requested review from jperals and removed request for a team December 23, 2025 11:07
@mxschll mxschll added this pull request to the merge queue Dec 23, 2025
Merged via the queue into main with commit 8b1948a Dec 23, 2025
50 checks passed
@mxschll mxschll deleted the dev-v3-schomax-AWSUI-61506 branch December 23, 2025 12:15
mxschll added a commit that referenced this pull request Dec 23, 2025
@mxschll mxschll restored the dev-v3-schomax-AWSUI-61506 branch December 23, 2025 17:19
ngynmt pushed a commit to ngynmt/components that referenced this pull request Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants