fix: wrap scrollToIndex in requestAnimationFrame#4132
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4132 +/- ##
==========================================
+ Coverage 97.13% 97.15% +0.02%
==========================================
Files 873 873
Lines 25562 25788 +226
Branches 9239 9378 +139
==========================================
+ Hits 24830 25055 +225
- Misses 726 727 +1
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jperals
approved these changes
Dec 23, 2025
NathanZlion
pushed a commit
that referenced
this pull request
Dec 24, 2025
ngynmt
pushed a commit
to ngynmt/components
that referenced
this pull request
Jan 5, 2026
ngynmt
pushed a commit
to ngynmt/components
that referenced
this pull request
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes incorrect scroll positioning in virtual lists by deferring
scrollToIndexcalls withrequestAnimationFrame. This ensures virtual items are measured before scrolling occurs.Related links, issue #, if available: n/a
How has this been tested?
Verified changes manually and in pipeline.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.