Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4136 +/- ##
=======================================
Coverage 97.16% 97.16%
=======================================
Files 879 879
Lines 25749 25749
Branches 9303 9303
=======================================
Hits 25018 25018
Misses 725 725
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cb18531 to
8b1eafe
Compare
8b1eafe to
112b41b
Compare
scripts/setup-build-tools.js
Outdated
| const copyBuildToolsPath = path.join(process.cwd(), 'shared', 'build-tools'); | ||
| execCommand(`mkdir -p ${copyBuildToolsPath}`); | ||
| execCommand(`rm -rf ${copyBuildToolsPath}`); | ||
| execCommand(`git clone --branch ${branch} --single-branch ${targetRepository} ${copyBuildToolsPath}`); |
There was a problem hiding this comment.
For such a simple command - can we inline that in the package.json?
E.g. "rimraf shared/build-tools && mkdir -p shared/build-tools && git clone --branch add-test-pages-util-permutation-view --single-branch https://github.com/cloudscape-design/build-tools.git shared/build-tools"
There was a problem hiding this comment.
I have updated the implementation like the following: instead of using a script we just add it to the package.json devDependencies, and then during build time we copy it to the /lib/dev-pages/internal/build-tools that way the package.json will be consistent with the other repositories as well.
1a32d68 to
b9edb46
Compare
2e08770 to
79ff41a
Compare
d78167d to
7081b45
Compare
|
This PR is going to be closed as we are going to start using the dev-pages utils from the build-tools after migration to vite for the dev pages. This is because right now using from build-tools would require us to make changes to the webpack configuration and we don't want to do that to keep things simple. |
Description
This PR allows us to use dev-page utils in components repository.
How does it work?
@cloudscape-design/build-toolswhich gets the package from GitHub - this works for running locally./lib/dev-pages/internal/build-toolsTested by:
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.