Skip to content

Conversation

@amanabiy
Copy link
Member

Description

Refactors the progress bar flash variant to use visual context styling instead of component-specific CSS classes and design tokens. This addresses the cleanup suggested in this review comment.

Potential Impact:
This change may affect builders who use variant='flash' outside of a flashbar context to control styling. However, the flash variant is intended exclusively for use within flashbar components.

For builders who need custom progress bar colors:

  • Use the public design tokens introduced in PR #4194
  • See the linked task (D382451383) for internal usage research and impact analysis

Related links: D382451383

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.17%. Comparing base (170fdf8) to head (e10c640).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4214      +/-   ##
==========================================
- Coverage   97.17%   97.17%   -0.01%     
==========================================
  Files         882      882              
  Lines       25824    25823       -1     
  Branches     9332     9331       -1     
==========================================
- Hits        25095    25094       -1     
  Misses        723      723              
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

* Enables the correct styling of the progress bar in different contexts. You can set it to one of the following:
*
* - `"flash"` - Use this variatn when using the progress bar within a flash component.
* - `"flash"` - Use this variant when using the progress bar within a flash component.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we deprecate this variant?

Copy link
Member Author

@amanabiy amanabiy Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the "flash" variant should not be deprecated. It has a functional purpose beyond styling the color like result button isn't displayed when using the flash variant.

@amanabiy amanabiy requested a review from pan-kot January 29, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants