-
Notifications
You must be signed in to change notification settings - Fork 211
refactor: use visual context for flash variant styling instead of design tokens #4214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4214 +/- ##
==========================================
- Coverage 97.17% 97.17% -0.01%
==========================================
Files 882 882
Lines 25824 25823 -1
Branches 9332 9331 -1
==========================================
- Hits 25095 25094 -1
Misses 723 723
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cd2b3ca to
6bca4cf
Compare
| * Enables the correct styling of the progress bar in different contexts. You can set it to one of the following: | ||
| * | ||
| * - `"flash"` - Use this variatn when using the progress bar within a flash component. | ||
| * - `"flash"` - Use this variant when using the progress bar within a flash component. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we deprecate this variant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the "flash" variant should not be deprecated. It has a functional purpose beyond styling the color like result button isn't displayed when using the flash variant.
6bca4cf to
e10c640
Compare
Description
Refactors the progress bar flash variant to use visual context styling instead of component-specific CSS classes and design tokens. This addresses the cleanup suggested in this review comment.
Potential Impact:
This change may affect builders who use
variant='flash'outside of a flashbar context to control styling. However, the flash variant is intended exclusively for use within flashbar components.For builders who need custom progress bar colors:
Related links: D382451383
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.