Skip to content

chore: Add Screenshot area for prompt input#4342

Merged
NathanZlion merged 3 commits intomainfrom
dev-v3-natidere-focus-ring-visual
Mar 12, 2026
Merged

chore: Add Screenshot area for prompt input#4342
NathanZlion merged 3 commits intomainfrom
dev-v3-natidere-focus-ring-visual

Conversation

@NathanZlion
Copy link
Copy Markdown
Member

@NathanZlion NathanZlion commented Mar 10, 2026

Description

Add screenshot area for testing.
Follow up for : #4322

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@NathanZlion NathanZlion force-pushed the dev-v3-natidere-focus-ring-visual branch from a842a65 to c2faa55 Compare March 10, 2026 09:34
@NathanZlion NathanZlion changed the title Dev v3 natidere focus ring visual chore: Add Screenshot area for prompt input Mar 10, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.44%. Comparing base (8093e3f) to head (d8bc6a6).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4342   +/-   ##
=======================================
  Coverage   97.44%   97.44%           
=======================================
  Files         897      897           
  Lines       26389    26389           
  Branches     9524     9525    +1     
=======================================
  Hits        25715    25715           
+ Misses        668      631   -37     
- Partials        6       43   +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines -73 to -76
if (textareaValue !== placeholderText) {
setUrlParams({ hasText: false });
}
// eslint-disable-next-line react-hooks/exhaustive-deps
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The setUrlParams in this file were messing up with the screenshot testing as it's changing the url path on first render.

@NathanZlion NathanZlion marked this pull request as ready for review March 11, 2026 13:45
@NathanZlion NathanZlion requested a review from a team as a code owner March 11, 2026 13:45
@NathanZlion NathanZlion requested review from Who-is-PS and removed request for a team March 11, 2026 13:45
@NathanZlion NathanZlion added this pull request to the merge queue Mar 12, 2026
Merged via the queue into main with commit 8b97e76 Mar 12, 2026
51 checks passed
@NathanZlion NathanZlion deleted the dev-v3-natidere-focus-ring-visual branch March 12, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants