Skip to content

chore: Clear feature notifications#4343

Merged
georgylobko merged 1 commit intomainfrom
chore/clear-feature-notifications
Mar 11, 2026
Merged

chore: Clear feature notifications#4343
georgylobko merged 1 commit intomainfrom
chore/clear-feature-notifications

Conversation

@georgylobko
Copy link
Copy Markdown
Member

Description

Updated clearFeatureNotifications to also clear initial messages, not just local state. This prevents feature notifications from being unnecessarily re-registered when the application remounts.

Related links, issue #, if available: n/a

How has this been tested?

U test / manual test

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.44%. Comparing base (8093e3f) to head (9e03f06).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4343   +/-   ##
=======================================
  Coverage   97.44%   97.44%           
=======================================
  Files         897      897           
  Lines       26389    26395    +6     
  Branches     9524     9525    +1     
=======================================
+ Hits        25715    25721    +6     
  Misses        668      668           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@georgylobko georgylobko marked this pull request as ready for review March 11, 2026 10:17
@georgylobko georgylobko requested a review from a team as a code owner March 11, 2026 10:17
@georgylobko georgylobko requested review from cansuaa and gethinwebster and removed request for a team March 11, 2026 10:17
@georgylobko georgylobko added this pull request to the merge queue Mar 11, 2026
Merged via the queue into main with commit 302fd0e Mar 11, 2026
49 checks passed
@georgylobko georgylobko deleted the chore/clear-feature-notifications branch March 11, 2026 13:57
amanabiy pushed a commit that referenced this pull request Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants