Skip to content

fix: Add aria-required to select/multiselect listbox element if set#4397

Merged
gethinwebster merged 2 commits intomainfrom
select-aria-required
Apr 1, 2026
Merged

fix: Add aria-required to select/multiselect listbox element if set#4397
gethinwebster merged 2 commits intomainfrom
select-aria-required

Conversation

@gethinwebster
Copy link
Copy Markdown
Member

@gethinwebster gethinwebster commented Mar 30, 2026

Description

Previously aria-required was only added to the filtering input (if present). This PR adds it also to the listbox as an additional affordance.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.45%. Comparing base (f7c23e9) to head (fae8556).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4397   +/-   ##
=======================================
  Coverage   97.45%   97.45%           
=======================================
  Files         909      909           
  Lines       26637    26637           
  Branches     9615     9615           
=======================================
  Hits        25958    25958           
  Misses        636      636           
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gethinwebster gethinwebster changed the title fix: Add aria-required to select listbox element if set fix: Add aria-required to select/multiselect listbox element if set Mar 31, 2026
@gethinwebster gethinwebster marked this pull request as ready for review March 31, 2026 07:43
@gethinwebster gethinwebster requested a review from a team as a code owner March 31, 2026 07:43
@gethinwebster gethinwebster requested review from SpyZzey and removed request for a team March 31, 2026 07:43
@gethinwebster gethinwebster added this pull request to the merge queue Apr 1, 2026
Merged via the queue into main with commit c631223 Apr 1, 2026
86 of 87 checks passed
@gethinwebster gethinwebster deleted the select-aria-required branch April 1, 2026 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants