Skip to content

chore: Add color prop to container style API#4399

Merged
mxschll merged 2 commits intomainfrom
jkuelz-container-styles
Mar 31, 2026
Merged

chore: Add color prop to container style API#4399
mxschll merged 2 commits intomainfrom
jkuelz-container-styles

Conversation

@jkuelz
Copy link
Copy Markdown
Member

@jkuelz jkuelz commented Mar 30, 2026

Description

Adds color prop to container's style.root property.

We allow changing the background color, so to enable accessible color combinations we should allow the default color to be changed as well. This allows components like Box to be used with color="inherit" and inherit the color defined.

P0 item from Venue sign-off.

Related links, issue #, if available: QuipZjcAA3fghsSF

How has this been tested?

Added an example to the custom-styles dev page for visual regression testing.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jkuelz jkuelz requested a review from mxschll March 30, 2026 17:33
@jkuelz jkuelz requested a review from a team as a code owner March 30, 2026 17:33
@mxschll
Copy link
Copy Markdown
Member

mxschll commented Mar 30, 2026

The snapshots need updating 😞

@jkuelz jkuelz force-pushed the jkuelz-container-styles branch from 115ba61 to 65ac0ee Compare March 31, 2026 01:29
@mxschll mxschll removed the request for review from a team March 31, 2026 08:46
@mxschll mxschll enabled auto-merge March 31, 2026 09:00
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.45%. Comparing base (a6cdcd0) to head (ac3a744).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4399   +/-   ##
=======================================
  Coverage   97.45%   97.45%           
=======================================
  Files         909      909           
  Lines       26637    26638    +1     
  Branches     9614     9616    +2     
=======================================
+ Hits        25958    25959    +1     
+ Misses        673      636   -37     
- Partials        6       43   +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mxschll mxschll added this pull request to the merge queue Mar 31, 2026
Merged via the queue into main with commit 1a54c66 Mar 31, 2026
49 checks passed
@mxschll mxschll deleted the jkuelz-container-styles branch March 31, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants