Skip to content

Conversation

@just-boris
Copy link
Member

@just-boris just-boris commented Jun 25, 2025

Issue #, if available:

Notes

Account for this use-case: https://github.com/cloudscape-design/components/blob/96ae8d04234f323f063b0d1a6ec4059c3412fa2a/src/button/interfaces.ts#L224

This object does not print nice in the API documentation and our squad decided that we truncate it for the time being

Testing

See the failed snapshot tests in dry-run builds. That diff is expected

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.45%. Comparing base (701c751) to head (027c283).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   91.42%   91.45%   +0.02%     
==========================================
  Files          16       16              
  Lines         910      913       +3     
  Branches      273      273              
==========================================
+ Hits          832      835       +3     
  Misses         77       77              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@just-boris just-boris marked this pull request as ready for review June 25, 2025 20:24
@just-boris just-boris requested a review from a team as a code owner June 25, 2025 20:24
@just-boris just-boris requested review from pan-kot and removed request for a team June 25, 2025 20:24
@just-boris just-boris enabled auto-merge June 26, 2025 08:01
@just-boris just-boris added this pull request to the merge queue Jun 26, 2025
Merged via the queue into main with commit a86a6ff Jun 26, 2025
34 of 35 checks passed
@just-boris just-boris deleted the compact-types branch June 26, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants