chore: Update new test-utils documenter #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
==========================================
+ Coverage 91.96% 92.04% +0.07%
==========================================
Files 15 15
Lines 909 918 +9
Branches 265 273 +8
==========================================
+ Hits 836 845 +9
Misses 73 73 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
just-boris
commented
Jul 27, 2025
|
|
||
| export interface TestUtilsVariantOptions { | ||
| root: string; | ||
| extraExports?: Array<string>; |
Member
Author
There was a problem hiding this comment.
Extra exports could be different for DOM and selectors code, this is why it is a separate config for each
just-boris
commented
Jul 27, 2025
| defaultValue: getDefaultValue(extractDeclaration(parameter)), | ||
| }; | ||
| }), | ||
| inheritedFrom: getInheritedFrom(declaration, className), |
Member
Author
There was a problem hiding this comment.
Changed fields order to maintain compatibility with previous snapshot tests
just-boris
commented
Jul 27, 2025
| const declaration = extractDeclaration(property); | ||
| const declaration = property.valueDeclaration; | ||
| if (!declaration) { | ||
| throw new Error(`Unexpected member on ${className} – ${property.getName()}`); |
Member
Author
There was a problem hiding this comment.
This line is not covered in tests. Because typescript says valueDeclaration could be undefined, but it always exists in our cases
johannes-weber
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Follow up for #77, some compatibility fixes with the old code
extraExportsoption to allow non-wrapper class export, for examplecreateWrapperfunctionBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.