Skip to content

Conversation

@just-boris
Copy link
Member

Issue #, if available:

Description of changes:

  1. Extract type-utils to shared directory because they used in both test-utils and components
  2. Update test-utils type remove some not needed optional flags

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@just-boris just-boris requested a review from a team as a code owner September 22, 2025 08:26
@just-boris just-boris requested review from jperals and removed request for a team September 22, 2025 08:26
@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

❌ Patch coverage is 95.65217% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.56%. Comparing base (34643d4) to head (c9ff200).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/components/extract-value-descriptions.ts 95.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
+ Coverage   96.30%   96.56%   +0.26%     
==========================================
  Files          10       11       +1     
  Lines         811      816       +5     
  Branches      277      274       -3     
==========================================
+ Hits          781      788       +7     
+ Misses         30       28       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not new code, that's how Github sees it after the rest of the code moved into ../shared

@just-boris just-boris added this pull request to the merge queue Sep 22, 2025
Merged via the queue into main with commit 40b7fda Sep 22, 2025
36 checks passed
@just-boris just-boris deleted the test-utils-new branch September 22, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants