Skip to content

chore: Make all global selectors apply uniformly#122

Merged
jkuelz merged 1 commit intomainfrom
jkuelz-theme-selector-test
Oct 20, 2025
Merged

chore: Make all global selectors apply uniformly#122
jkuelz merged 1 commit intomainfrom
jkuelz-theme-selector-test

Conversation

@jkuelz
Copy link
Member

@jkuelz jkuelz commented Oct 17, 2025

Issue #, if available:

Description of changes:
A global class can be one of :root, html, or body. This fix ensures all global selectors are treated the same.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jkuelz jkuelz requested a review from a team as a code owner October 17, 2025 01:56
@jkuelz jkuelz requested review from taheramr and removed request for a team October 17, 2025 01:56
@jkuelz jkuelz force-pushed the jkuelz-theme-selector-test branch from 1c54dc3 to 871e7cb Compare October 17, 2025 02:01
@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.38%. Comparing base (a168ef5) to head (871e7cb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #122   +/-   ##
=======================================
  Coverage   97.38%   97.38%           
=======================================
  Files          45       45           
  Lines        2139     2140    +1     
  Branches      405      401    -4     
=======================================
+ Hits         2083     2084    +1     
  Misses         56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jkuelz jkuelz requested a review from just-boris October 17, 2025 16:38
@jkuelz jkuelz added this pull request to the merge queue Oct 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 20, 2025
@jkuelz jkuelz added this pull request to the merge queue Oct 20, 2025
Merged via the queue into main with commit 6c922ae Oct 20, 2025
42 checks passed
@jkuelz jkuelz deleted the jkuelz-theme-selector-test branch October 20, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants