feat: add validation for letter spacing that allows negative values#138
Merged
feat: add validation for letter spacing that allows negative values#138
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 48 48
Lines 2612 2616 +4
Branches 508 540 +32
=======================================
+ Hits 2547 2551 +4
Misses 65 65 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
amanabiy
reviewed
Feb 20, 2026
| }; | ||
| const letterSpacingValueSchema: GenericSchema = { | ||
| type: 'string', | ||
| pattern: 'normal|inherit|initial|revert|revert-layer|unset|-?\\d*\\.?\\d+(px|rem|em)', |
Member
There was a problem hiding this comment.
This pattern match partial strings like revert-something or 12px extra-text. Should we use anchors and word boundaries to ensure only exact matches are accepted something like this: ^(\b(normal|inherit|initial|revert-layer|revert|unset)\b|-?\d*\.?\d+(px|rem|em))$.
I see the others also have similar implementation so I am wondering if we can do this maybe as a follow up.
amanabiy
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
We want to make our heading letter-spacing tokens public and themable. However, because these tokens can contain negative values (which are valid), the current validation fails, preventing us from making them public. This PR separates letter-spacing validation from other font-sizing logic.
With this change, css keyword values are possible and numeric values in the following format:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.