Fix regression in RDS validator #2346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated the line and it ran without issue. However, looking at this it may need to be done for 14484- if engine in ["mariadb", "mysql", "postgres"]:
14539- min_storage_size = 400
14574- elif engine in ["oracle"]:
14609- min_storage_size = 200
14644- elif engine.startswith("sqlserver"):
14689- min_storage_size = 20
14723- min_iops_to_allocated_storage_ratio = 0.5
14777- else:
14791- raise ValueError(
14821: f"StorageType gp3 is not supported for engine " f"{engine}"
14897- ) |
yamjoepobuda
approved these changes
Dec 3, 2025
yamjoepobuda
left a comment
yamjoepobuda
left a comment
There was a problem hiding this comment.
Change is good as-is to resolve the reported issue, but oracle may have regressed as well.
Member
Author
|
Thank you for the review. Good catch on the oracle change. I pushed a new version and added tests as well for both of them. Can you take a look before a merge? |
yamjoepobuda
approved these changes
Dec 3, 2025
yamjoepobuda
left a comment
yamjoepobuda
left a comment
There was a problem hiding this comment.
lgtm, thank you for looking into this quickly!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yamjoepobuda I think this is more explicit to fix the regression. Can you verify and approve?