generated from cloudwego/.github
-
Notifications
You must be signed in to change notification settings - Fork 43
fix: pass all go tests in lang/ #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* lang/lsp/utils_test.go: no change * lang/lsp/client_test.go: test basic LSP clients * lang/lsp/lsp_test.go: removed because `TestDocumentSymbol_MarshalJSON` is covered in client_test.go
Collaborator
Author
statusTo check, run # TODO: go
bash -c '( set -ex ; for completed in ./lang/{lsp,collect,uniast,rust,} ; do echo $completed ; go test $completed ; done )'
|
Pending lang/patch tests because localsession.json contains paths on Yi's machine. Freshly generating localsession.json fixes the issue, but let's confirm.
Collaborator
Author
|
@AsterDY The PR is almost ready, would it be convenient for you to review next week? Failing TestsPackage lang/patch
We could
Package lang/golang
We could
Other caveats and potential inconsistencies
|
Collaborator
|
CI也顺便加一下? |
Collaborator
Author
|
done
|
AsterDY
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a WIP attempting to make
go testwork.Involving:
*_test.gofiles. Including tests scaffolds, removing hardcoded paths etc.Check the PR title.
(Optional) Translate the PR title into Chinese.
修复文件,完事能用上 go test。这样无论我们 CI 还是别人 PR 都方便。
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: