Skip to content

fix(local): replace bufio.Scanner with bufio.Reader, implement Execute, and merge stderr to stdout in code template#735

Merged
zhuangjie1125 merged 2 commits intomainfrom
fix/local
Mar 23, 2026
Merged

fix(local): replace bufio.Scanner with bufio.Reader, implement Execute, and merge stderr to stdout in code template#735
zhuangjie1125 merged 2 commits intomainfrom
fix/local

Conversation

@zhuangjie1125
Copy link
Copy Markdown
Contributor

@zhuangjie1125 zhuangjie1125 commented Mar 17, 2026

  • Replace bufio.Scanner with bufio.Reader in streamStdout to handle long lines
  • Implement Local.Execute using exec.CommandContext with /bin/sh -c
  • Merge stderr output into stdout with labeled sections in executePythonCodeTemplate
  • Add unit tests for Execute method

@github-actions
Copy link
Copy Markdown

Need to create a new tag

The following modules have changes and may need version updates:

  • adk/backend/local (Current: adk/backend/local/v0.2.3)

⚠️ Please create and push new version tags for these modules after merging this PR.

@github-actions
Copy link
Copy Markdown

Need to create a new tag

The following modules have changes and may need version updates:

  • adk/backend/local (Current: adk/backend/local/v0.2.3)

⚠️ Please create and push new version tags for these modules after merging this PR.

@github-actions
Copy link
Copy Markdown

Need to create a new tag

The following modules have changes and may need version updates:

  • adk/backend/local (Current: adk/backend/local/v0.2.3)

  • adk/backend/agentkit (Current: adk/backend/agentkit/v0.2.4)

⚠️ Please create and push new version tags for these modules after merging this PR.

@github-actions
Copy link
Copy Markdown

Need to create a new tag

The following modules have changes and may need version updates:

  • adk/backend/local (Current: adk/backend/local/v0.2.3)

  • adk/backend/agentkit (Current: adk/backend/agentkit/v0.2.4)

⚠️ Please create and push new version tags for these modules after merging this PR.

@zhuangjie1125 zhuangjie1125 changed the title fix(local): replace bufio.Scanner with bufio.Reader and implement Execute fix(local): replace bufio.Scanner with bufio.Reader, implement Execute, and merge stderr to stdout in code template Mar 20, 2026
@github-actions
Copy link
Copy Markdown

Need to create a new tag

The following modules have changes and may need version updates:

  • adk/backend/local (Current: adk/backend/local/v0.2.3)

  • adk/backend/agentkit (Current: adk/backend/agentkit/v0.2.4)

⚠️ Please create and push new version tags for these modules after merging this PR.

@github-actions
Copy link
Copy Markdown

Need to create a new tag

The following modules have changes and may need version updates:

  • adk/backend/local (Current: adk/backend/local/v0.2.3)

  • adk/backend/agentkit (Current: adk/backend/agentkit/v0.2.4)

⚠️ Please create and push new version tags for these modules after merging this PR.

1 similar comment
@github-actions
Copy link
Copy Markdown

Need to create a new tag

The following modules have changes and may need version updates:

  • adk/backend/local (Current: adk/backend/local/v0.2.3)

  • adk/backend/agentkit (Current: adk/backend/agentkit/v0.2.4)

⚠️ Please create and push new version tags for these modules after merging this PR.

@github-actions
Copy link
Copy Markdown

Need to create a new tag

The following modules have changes and may need version updates:

  • adk/backend/local (Current: adk/backend/local/v0.2.3)

  • adk/backend/agentkit (Current: adk/backend/agentkit/v0.2.4)

⚠️ Please create and push new version tags for these modules after merging this PR.

1 similar comment
@github-actions
Copy link
Copy Markdown

Need to create a new tag

The following modules have changes and may need version updates:

  • adk/backend/local (Current: adk/backend/local/v0.2.3)

  • adk/backend/agentkit (Current: adk/backend/agentkit/v0.2.4)

⚠️ Please create and push new version tags for these modules after merging this PR.

@github-actions
Copy link
Copy Markdown

Need to create a new tag

The following modules have changes and may need version updates:

  • adk/backend/local (Current: adk/backend/local/v0.2.3)

  • adk/backend/agentkit (Current: adk/backend/agentkit/v0.2.4)

⚠️ Please create and push new version tags for these modules after merging this PR.

…e, and merge stderr to stdout in code template

- Replace bufio.Scanner with bufio.Reader in streamStdout to handle long lines
- Implement Local.Execute using exec.CommandContext with /bin/sh -c
- Merge stderr output into stdout with labeled sections in executePythonCodeTemplate
- Add unit tests for Execute method
@github-actions
Copy link
Copy Markdown

Need to create a new tag

The following modules have changes and may need version updates:

  • adk/backend/local (Current: adk/backend/local/v0.2.3)

  • adk/backend/agentkit (Current: adk/backend/agentkit/v0.2.4)

⚠️ Please create and push new version tags for these modules after merging this PR.

@zhuangjie1125 zhuangjie1125 disabled auto-merge March 23, 2026 11:10
@zhuangjie1125 zhuangjie1125 enabled auto-merge (squash) March 23, 2026 11:10
@github-actions
Copy link
Copy Markdown

Need to create a new tag

The following modules have changes and may need version updates:

  • adk/backend/local (Current: adk/backend/local/v0.2.3)

  • adk/backend/agentkit (Current: adk/backend/agentkit/v0.2.4)

⚠️ Please create and push new version tags for these modules after merging this PR.

@zhuangjie1125 zhuangjie1125 disabled auto-merge March 23, 2026 11:22
@zhuangjie1125 zhuangjie1125 enabled auto-merge (squash) March 23, 2026 11:22
@zhuangjie1125 zhuangjie1125 merged commit f061db7 into main Mar 23, 2026
7 checks passed
@zhuangjie1125 zhuangjie1125 deleted the fix/local branch March 23, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants