Skip to content

Conversation

@meguminnnnnnnnn
Copy link
Contributor

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@codecov
Copy link

codecov bot commented Jan 4, 2026

Codecov Report

❌ Patch coverage is 85.23490% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.57%. Comparing base (3d494c0) to head (acb5b1b).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
adk/middlewares/skill/skill.go 76.47% 8 Missing and 8 partials ⚠️
adk/middlewares/skill/local.go 92.59% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #661      +/-   ##
==========================================
+ Coverage   81.53%   81.57%   +0.04%     
==========================================
  Files         124      127       +3     
  Lines       12020    12250     +230     
==========================================
+ Hits         9800     9993     +193     
- Misses       1495     1514      +19     
- Partials      725      743      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@turingboot
Copy link

hi team!thanks for ur works. When is this skills feature roughly expected to be merged? This is a promising feature, and we look forward to its integration.

@hi-pender
Copy link
Contributor

hi team!thanks for ur works. When is this skills feature roughly expected to be merged? This is a promising feature, and we look forward to its integration.

it maybe released on the end of this week

@meguminnnnnnnnn meguminnnnnnnnn force-pushed the feat/wdz/adk_skill branch 5 times, most recently from 2dec249 to ca307c3 Compare January 9, 2026 03:44
@turingboot
Copy link

hi team!thanks for ur works. When is this skills feature roughly expected to be merged? This is a promising feature, and we look forward to its integration.

it maybe released on the end of this week

I noticed the PR is still pending review. Would you be able to share a rough timeline for when it might be merged?
Thank you for your effort on this.

@meguminnnnnnnnn meguminnnnnnnnn force-pushed the feat/wdz/adk_skill branch 4 times, most recently from d7998bb to ddb8f75 Compare January 20, 2026 13:33
@hi-pender hi-pender merged commit 38efb3c into main Jan 21, 2026
19 checks passed
@hi-pender hi-pender deleted the feat/wdz/adk_skill branch January 21, 2026 09:08
@hi-pender
Copy link
Contributor

hi-pender commented Jan 21, 2026

hi team!thanks for ur works. When is this skills feature roughly expected to be merged? This is a promising feature, and we look forward to its integration.

it maybe released on the end of this week

I noticed the PR is still pending review. Would you be able to share a rough timeline for when it might be merged? Thank you for your effort on this.

@turingboot it's merged now
https://github.com/cloudwego/eino/releases/tag/v0.7.23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants