Skip to content

fix: sse read and close race issue #1473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jayantxie wants to merge 2 commits into
base: develop
Choose a base branch
from

test: add race detected tests

d8c98a4
Select commit
Loading
Failed to load commit list.
Open

fix: sse read and close race issue #1473

test: add race detected tests
d8c98a4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 5, 2026 in 0s

86.56% (+12.35%) compared to 15146d0

View this Pull Request on Codecov

86.56% (+12.35%) compared to 15146d0

Details

Codecov Report

❌ Patch coverage is 90.38462% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.56%. Comparing base (15146d0) to head (d8c98a4).
⚠️ Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
pkg/protocol/sse/reader.go 90.38% 4 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           develop    #1473       +/-   ##
============================================
+ Coverage    74.20%   86.56%   +12.35%     
============================================
  Files          147      149        +2     
  Lines        17006    14851     -2155     
============================================
+ Hits         12620    12856      +236     
+ Misses        3792     1457     -2335     
+ Partials       594      538       -56

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov