Skip to content

Comments

fix(pilota-thrift-parser): adapt the thrift annotation syntax#353

Merged
Ggiggle merged 1 commit intomainfrom
fix/annotation_parser
Nov 19, 2025
Merged

fix(pilota-thrift-parser): adapt the thrift annotation syntax#353
Ggiggle merged 1 commit intomainfrom
fix/annotation_parser

Conversation

@Ggiggle
Copy link
Collaborator

@Ggiggle Ggiggle commented Nov 19, 2025

Motivation

The annotation syntax is not defined in the official web. As there are existing idls, we should try best to be compatible with them.

Solution

We allow the annotations syntax below:

AnnotationList ::= Annotation (ListSeparator Annotation)* ListSeparator?
Annotation ::= Identifier "=" Literal
ListSeparator ::= "," | ";"

// For example.

(
            cpp.type = "DenseFoo",
            python.type ="DenseFoo", 
            go.type ="DenseFoo";
            java.final=""
        )

@Ggiggle Ggiggle requested review from a team as code owners November 19, 2025 12:34
@Ggiggle Ggiggle force-pushed the fix/annotation_parser branch from 3833cf7 to 9dce4f2 Compare November 19, 2025 12:36
@Ggiggle Ggiggle merged commit f6aa3f6 into main Nov 19, 2025
19 of 21 checks passed
@Ggiggle Ggiggle deleted the fix/annotation_parser branch November 19, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants