Skip to content

Comments

fix(pilota-thrift-parser): when parsing fields, all allowed whitespace locations need to be considered as non-newline comments#356

Merged
Ggiggle merged 1 commit intomainfrom
fix/thrift_field_parser
Dec 17, 2025
Merged

fix(pilota-thrift-parser): when parsing fields, all allowed whitespace locations need to be considered as non-newline comments#356
Ggiggle merged 1 commit intomainfrom
fix/thrift_field_parser

Conversation

@Ggiggle
Copy link
Collaborator

@Ggiggle Ggiggle commented Dec 17, 2025

Motivation

Thrift IDL like,

struct Val {
	1: string id  /** abc */ (go.tag="")
	2: string name
}

will encounter parser error, because we process blank just following the field ident incorrectly.

Solution

when parsing fields, all allowed whitespace locations need to be considered as non-newline comments

…e locations need to be considered as non-newline comments
@Ggiggle Ggiggle requested review from a team as code owners December 17, 2025 07:33
@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.37%. Comparing base (8f44731) to head (250548d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
+ Coverage   66.32%   66.37%   +0.04%     
==========================================
  Files          88       88              
  Lines       24574    24574              
==========================================
+ Hits        16299    16310      +11     
+ Misses       8275     8264      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Ggiggle Ggiggle merged commit 29ec096 into main Dec 17, 2025
16 checks passed
@Ggiggle Ggiggle deleted the fix/thrift_field_parser branch December 17, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants