feat(pilota-build): add with_comments option for builder#358
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #358 +/- ##
==========================================
+ Coverage 66.37% 66.52% +0.15%
==========================================
Files 88 88
Lines 24577 24699 +122
==========================================
+ Hits 16312 16432 +120
- Misses 8265 8267 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
86191ba to
d027a61
Compare
d027a61 to
2dc5a85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The comments in user idl, will be checked by rust compiler, when these comments are generated in rust file.
Solution
We add a option for the control of comments, so when you need comments codegen, you should make sure that your comments is compatible with rust format.