Skip to content

Comments

feat(pilota-build): add with_comments option for builder#358

Merged
Ggiggle merged 1 commit intomainfrom
feat/comment_opt
Dec 29, 2025
Merged

feat(pilota-build): add with_comments option for builder#358
Ggiggle merged 1 commit intomainfrom
feat/comment_opt

Conversation

@Ggiggle
Copy link
Collaborator

@Ggiggle Ggiggle commented Dec 25, 2025

Motivation

The comments in user idl, will be checked by rust compiler, when these comments are generated in rust file.

Solution

We add a option for the control of comments, so when you need comments codegen, you should make sure that your comments is compatible with rust format.

@Ggiggle Ggiggle requested review from a team as code owners December 25, 2025 07:47
@codecov
Copy link

codecov bot commented Dec 25, 2025

Codecov Report

❌ Patch coverage is 98.28571% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.52%. Comparing base (67eb3ec) to head (d027a61).

Files with missing lines Patch % Lines
pilota-build/src/lib.rs 81.81% 2 Missing ⚠️
pilota-build/src/codegen/mod.rs 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #358      +/-   ##
==========================================
+ Coverage   66.37%   66.52%   +0.15%     
==========================================
  Files          88       88              
  Lines       24577    24699     +122     
==========================================
+ Hits        16312    16432     +120     
- Misses       8265     8267       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Ggiggle Ggiggle force-pushed the feat/comment_opt branch 4 times, most recently from 86191ba to d027a61 Compare December 29, 2025 10:44
@Ggiggle Ggiggle merged commit 6cf339d into main Dec 29, 2025
8 of 12 checks passed
@Ggiggle Ggiggle deleted the feat/comment_opt branch December 29, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant