Skip to content

Update close handler to avoid unhandled promise rejections #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2023
Merged

Update close handler to avoid unhandled promise rejections #42

merged 1 commit into from
Jul 10, 2023

Conversation

clue
Copy link
Owner

@clue clue commented Jul 8, 2023

@clue clue added bug Something isn't working new feature New feature or request labels Jul 8, 2023
@clue clue added this to the v1.2.0 milestone Jul 8, 2023
@clue clue requested a review from SimonFrings July 8, 2023 13:29
@clue clue force-pushed the unhandled-rejections branch from 8eaf4fe to df050ae Compare July 8, 2023 13:33
@SimonFrings SimonFrings merged commit c11d91a into clue:1.x Jul 10, 2023
@SimonFrings SimonFrings deleted the unhandled-rejections branch July 10, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@SimonFrings SimonFrings SimonFrings approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working new feature New feature or request

Projects

None yet

Milestone

v1.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@clue @SimonFrings