Skip to content

Update close handler to avoid unhandled promise rejections #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2024
Merged

Update close handler to avoid unhandled promise rejections #56

merged 1 commit into from
Apr 9, 2024

Conversation

SimonFrings
Copy link
Contributor

Builds on top of reactphp/promise#248 and #44

@SimonFrings SimonFrings requested a review from clue April 9, 2024 07:59
@clue clue added this to the v1.9.0 milestone Apr 9, 2024
clue
clue approved these changes Apr 9, 2024
View reviewed changes
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for looking into this, changes LGTM! :shipit:

@clue clue merged commit c5f8a2c into clue:1.x Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clue clue clue approved these changes

Assignees

No one assigned

Labels

bug new feature

Projects

None yet

Milestone

v1.9.0

Development

Successfully merging this pull request may close these issues.

2 participants

@SimonFrings @clue